The compile step fails at the end if you change the default folder for the build files. #2257
Labels
No labels
accessibility
autorelease: pending
autorelease: tagged
bug
dependencies
documentation
duplicate
enhancement
github_actions
good first issue
help wanted
invalid
question
testing wanted
wontfix
No milestone
No assignees
1 participant
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Hookshot#2257
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Builder version
2.1.0
How you built
Hookshot Builder app (Windows)
Game files given to it
A .nup
The error
Visual Studio or Build Tools version, and Windows SDK version
No response
Operating system and free space on the output drive
Windows 10 22H2 (OS Build 19045.7807) 135GB free on output drive
Before you send it
This is the comma in the folder's path. Both error lines begin right after one:
The build hands the link map's path and the link order's path to the linker through
-Wl,, and the compiler splits that at every comma, so the linker only gets the part of each path after the,. Any build files folder with a comma somewhere in its full path fails like this, at the link, after the whole compile (yours sayscompiled in 427s, 0 failed).Until it's fixed: pick a build files folder with no comma anywhere in its path (for example
C:\HookshotBuild), or keep the default, which your title says works.The fix is #2137 (open, not merged yet): it passes those two paths to the linker as single arguments. It was tested on Linux, and on Windows with linker fixtures (the comment there); nobody has run a full Builder build on Windows with it yet.
Good to know. It was on an issue on build 2.0.14.
Thanks for the report. Reports of the same problem are now collected in #2505, which lists this one with your details and links back here, so one fix closes them together and the open list stays readable. Follow #2505 for the fix, and add new details there (or here). If this turns out to be a separate problem it will be reopened. Pull request #2137 works on this.