FSR 4 does not appear as an option #2188
Labels
No labels
accessibility
autorelease: pending
autorelease: tagged
bug
dependencies
documentation
duplicate
enhancement
github_actions
good first issue
help wanted
invalid
question
testing wanted
wontfix
No milestone
No assignees
1 participant
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Hookshot#2188
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Hookshot version
v2.1.0
What kind of problem
Something else
What happened
I did check the FSR4 SDK checkbox on the builder but the only scaler choices the F1 gives me are Native or FSR 3.1
Where in the game
Menu
How often
Every time
Graphics card and driver version
rx 9070 xt, driver 26.10.1
CPU, RAM and operating system
Ryzen 9 5900X, 32GB, Windows 11
Changes from the defaults
No response
Other software hooked into the game
No, nothing hooked in
hookshot_log.txt
hookshot_log.txt
Screenshots or video
No response
Before you send it
Experienced this as well, coming from the RC3 build, I think maybe it didnt' carry over the FSR4 python scripts, and there's no simple way to force the builder to redownload the dependencies I'm aware of.
Edit: clearing my build tools in appdata, and redownloading the builder, the scripts folder is missing ffx_sdk.py, so the checkbox is likely silently failing. I downloaded the script and ran it directly myself to place the dlls in the expected locations for the build tools, and am rebuilding now.
This worked. I would advise deleting your build folder and letting it re-download. Once it has, close it, and manually add the ffx_sdk.py to the scripts folder, and from the tools folder, run the command:
python -I scripts/ffx_sdk.py --accept-amd-license --game <game folder>This will put the ffx sdk dlls into the work/ffx-sdk directory, and copy them to the compiled game's /bin folder as well. Once this is done, check the checkbox as before and then compile, and the builder will recognize the dlls are present and build with FSR4 enabled.
Could you please specify which folder should be deleted ? I looked around the Hookshot folder in Appdata but couldn't find one called build.
I deleted the entire HookshotBuilder folder, redownloaded it from the github, redownloaded all the files, but it still doesnt show FSR4 in game (9070 XT).
Thanks !
EDIT - I figured it out.
For anyone else not seeing FSR4 as an option in Hookshot's settings after updating to 2.1.0 :
C:\Users\your-user\AppData\Local\HookshotBuilder\versions\v2.1.0\HookshotBuilder\tools\scripts.\python.exe -I ..\scripts/ffx_sdk.py --accept-amd-license --game <game folder>replacing by your installation of Hookshot.i need the linux tutorial, seems cannot found the builder folder in .local/hookshot/HookshotBuilder/ folder
Im stuck on this part. I replace the with "D:\OOT" but it says no such file or directory
That command is wrong, because you can't call the script from the the python folder like that.
First make sure than the file ffx_sdk.py exists and it's not empty, if it's empty just put the contents of https://git.magicbean.dev/MagicBeanDev/Hookshot/src/branch/main/scripts/ffx_sdk.py on it, then go to go to the tools folder and use:
.\python\python.exe -I scripts/ffx_sdk.py --accept-amd-license --game <game folder>After that I didn't need to build again and FSR4 worked in game
ok so I pasted the contents of that script you sent in the ffx_sdk.py. but when I run the
.\python\python.exe -I scripts/ffx_sdk.py --accept-amd-license --game <game folder>what do I replace the game folder part with?The folder that in the builder appears under
ok, command ran fine in powershell but I didn't see the FSR4 option in game
alright what worked for me was to delete the tools folder
C:\Users\your-user\AppData\Local\HookshotBuilder\versions\v2.1.0\HookshotBuilder\toolsand rebuild the recomp from the Hookshot exe after reselecting the .nup fileMy bad, I forgot to add the step where we add the content of the python script.
For the execution of the script, I corrected the path to the \scripts\ folder that was incorrect, but calling .\python.exe is perfectly fine if you start your Powershell in \python
For anyone on Linux following this thread: the ffx_sdk.py workaround above only works on Windows. The Linux AppImage doesn't support FSR 4 at the moment, so FSR 4 won't show in the Upscaler row however the build is set up.
Why:
The Linux code for FSR 4 is in the project (gpu/vk/vk_fsr4.cpp, from #857/#1008), and CI checks that it compiles. Right now the only way to use it is to build hookshot_vk.so from source with HOOKSHOT_FSR=1 at the same version as your AppImage, put it in the game's bin/ folder, and add amd_fidelityfx_upscaler_vk.so next to it. The AppImage's update puts its own renderer back, so you'd have to redo this after every update.
If we want to keep this issue solely about Windows builder, we can open a separate issue to track FSR 4 in the Linux AppImage perhaps. Otherwise - we can track both here.
Thanks for the report. Reports of the same problem are now collected in #2511, which lists this one with your details and links back here, so one fix closes them together and the open list stays readable. Follow #2511 for the fix, and add new details there (or here). If this turns out to be a separate problem it will be reopened.