Renderer source fixtures fail after stream and descriptor admission merges #1813

Closed

opened 2026-11-10 17:24:45 +00:00 by Arkex-ai · 0 comments

Arkex-ai commented

2026-11-10 17:24:45 +00:00

(Migrated from github.com)

Two game-free source fixtures no longer compile after the renderer admission changes in #1658 and #1754 merged. Reproduced on untouched main 52ac35ca with Windows LLVM:

tests/test_draw_stream_visibility.py: use of undeclared identifier 'stream_insert'. The real stream allocation and recording reset now depend on that production helper, but the fixture does not extract it.
tests/test_sampler_admission.py: use of undeclared identifier 'vkDestroyDescriptorPool'. The complete descriptor binder now references owning-pool rollback, and the fixture lacks that Vulkan environment entry point.

The exact main full suite reports268 passed/7 failed/20 skipped; a separate candidate adds one passing check and has the same seven failures. This issue covers only these two renderer fixture integration failures. #1793 owns PREPARE and saved-key aliases; a long-path fixture finding is also reported there.

Proposed fix: restore the actual helper dependency and the modeled Vulkan environment without changing production behavior, suppressing warnings or weakening existing assertions. Validate all16 stream scenarios and108 sampler cases on Windows and Linux, plus sanitizers and exact-head CI. No game/runtime improvement is claimed for a test-only repair.

Claim: issai / Arkex-ai in #dev-work, before implementation. Priority: CI-first under the workflow; S3 x reach1.0 x confidence1.0 =1.0. I can test Windows/RTX5070Ti and Linux CPU fixtures. No native failure injection is involved.

Two game-free source fixtures no longer compile after the renderer admission changes in #1658 and #1754 merged. Reproduced on untouched main `52ac35ca` with Windows LLVM: - `tests/test_draw_stream_visibility.py`: `use of undeclared identifier 'stream_insert'`. The real stream allocation and recording reset now depend on that production helper, but the fixture does not extract it. - `tests/test_sampler_admission.py`: `use of undeclared identifier 'vkDestroyDescriptorPool'`. The complete descriptor binder now references owning-pool rollback, and the fixture lacks that Vulkan environment entry point. The exact main full suite reports268 passed/7 failed/20 skipped; a separate candidate adds one passing check and has the same seven failures. This issue covers only these two renderer fixture integration failures. #1793 owns PREPARE and saved-key aliases; a long-path fixture finding is also reported there. Proposed fix: restore the actual helper dependency and the modeled Vulkan environment without changing production behavior, suppressing warnings or weakening existing assertions. Validate all16 stream scenarios and108 sampler cases on Windows and Linux, plus sanitizers and exact-head CI. No game/runtime improvement is claimed for a test-only repair. Claim: [issai / Arkex-ai in #dev-work](https://discord.com/channels/1568810484818378804/1569019786766188665/1569763504758464609), before implementation. Priority: CI-first under the workflow; S3 x reach1.0 x confidence1.0 =1.0. I can test Windows/RTX5070Ti and Linux CPU fixtures. No native failure injection is involved.

Commenting is not possible because the repository is archived.