test(nup): the stand-in test's stub takes the progress #1764 passes (main is red) #1790

Closed

Joey-Magnus wants to merge 1 commit from fix/test-stand-in-progress into main

Joey-Magnus commented

2026-11-10 16:48:18 +00:00

(Migrated from github.com)

nx2/test_nup_stand_in.py fails on main since #1764: make_game.stand_in_damaged_files now calls nup.stand_in_damaged(romfs, progress), and the test's stub of stand_in_damaged took only romfs (TypeError: <lambda>() takes 1 positional argument but 2 were given).

The stub now takes the progress callback, and the test also checks that one is passed (the builder's bar from #1764). The code under test is unchanged.

python -I -B nx2/test_nup_stand_in.py: ok. run_all.py: 246 passed, 0 failed (Linux; 1 failed on main before).

🤖 Generated with Claude Code

`nx2/test_nup_stand_in.py` fails on `main` since #1764: `make_game.stand_in_damaged_files` now calls `nup.stand_in_damaged(romfs, progress)`, and the test's stub of `stand_in_damaged` took only `romfs` (`TypeError: <lambda>() takes 1 positional argument but 2 were given`). The stub now takes the progress callback, and the test also checks that one is passed (the builder's bar from #1764). The code under test is unchanged. `python -I -B nx2/test_nup_stand_in.py`: ok. `run_all.py`: 246 passed, 0 failed (Linux; 1 failed on `main` before). 🤖 Generated with [Claude Code](https://claude.com/claude-code)

Joey-Magnus commented

2026-11-10 17:48:55 +00:00

(Migrated from github.com)