fix: Discord status starts on Windows #1539
No reviewers
Labels
No labels
accessibility
autorelease: pending
autorelease: tagged
bug
dependencies
documentation
duplicate
enhancement
github_actions
good first issue
help wanted
invalid
question
testing wanted
wontfix
No milestone
No assignees
1 participant
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Hookshot!1539
Loading…
Reference in a new issue
No description provided.
Delete branch "fix/discord-windows"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The Discord status (
host/discord_rpc.c, #1485) was started only from the Linux build'smain(inside#ifndef _WIN32). On Windows it never ran: no status, and nodiscord:line in any log. Found while checking the v2.0.12 candidate's verify logs. This starts it on Windows too, after the argument loop, so a--prepare-shadersrun, which returns inside that loop, never starts it.HOS_DISCORD=0and the menu row still turn it off.Tested: compiles cleanly (
-Wall -Wextra; the three warnings are pre-existing). An in-game check (the log'sdiscord:lines with a Discord client running) is next, on the release build.🤖 Generated with Claude Code