fix(menu): Quality presets leave Frame generation alone, so it stays off by default #1526

Merged

hckrman101 merged 1 commit from framegen-off-by-default into main

2026-11-10 06:35:49 +00:00

hckrman101 commented

2026-11-10 06:34:52 +00:00

(Migrated from github.com)

apply_preset no longer sets Frame generation. Its default was already Off; now no preset changes it.
The Frame generation row is preset-exempt, like the controls and the window rows: changing it no longer sets the preset back to Custom.
The preset hints and the readme no longer list made frames. While there, the hints' Sharpness values now match what the presets actually set (30, 30, 30, 40, 50; they still listed the old 50, 35, 25, 30, 40).
The RX_VK_LOW_SPEC first-run path no longer needs to turn frame generation back off.

Existing hookshot_options.ini files keep whatever Frame generation they have; only choosing a preset changes.

How it was tested: python -I -B tests/run_all.py: 236 passed, 0 failed. No visual change to the menu itself, so no screenshots.

Picking any Quality preset turns Frame generation on (2x, or 3x for Ultra), so most players end up with made frames, and their input delay and artifacts, without asking for them. Frame generation should be off unless the player turns it on. - `apply_preset` no longer sets Frame generation. Its default was already Off; now no preset changes it. - The Frame generation row is preset-exempt, like the controls and the window rows: changing it no longer sets the preset back to Custom. - The preset hints and the readme no longer list made frames. While there, the hints' Sharpness values now match what the presets actually set (30, 30, 30, 40, 50; they still listed the old 50, 35, 25, 30, 40). - The `RX_VK_LOW_SPEC` first-run path no longer needs to turn frame generation back off. Existing `hookshot_options.ini` files keep whatever Frame generation they have; only choosing a preset changes. **How it was tested:** `python -I -B tests/run_all.py`: 236 passed, 0 failed. No visual change to the menu itself, so no screenshots.

Commenting is not possible because the repository is archived.

No reviewers