fix: restore shader answer-domain regression fixture #1076

Closed

nickyfactz wants to merge 1 commit from fix/shader-answer-domain-fixture into main

nickyfactz commented

2026-11-09 09:37:37 +00:00

(Migrated from github.com)

After the pipeline-state-list and answer-domain changes landed together, test_program_answer_domains.py no longer compiles: the extracted production record_answers function reads the thread-local answers_in, but the fixture did not define it. The current main source-regression run fails on both Windows and Linux.

Add the fixture's missing input and check that pipeline-state answers are retained in the recorded variant. The renderer and runtime are unchanged.

Validation:

Windows Clang/MSVC: reproduced the undeclared identifier on main; the focused fixture now passes its five default/strict environment cases. python -I -B tests/run_all.py --strict program_answer_domains passes.
WSL GCC: reproduced the same failure and verified the five cases pass after the fix, with -D_Static_assert=static_assert for the local GCC compiler.
A negative control that disables the production answers_in branch fails the new assertion.
git diff --check passes. Upstream PR checks for this commit have not run yet.

Assisted-by: OpenAI Codex

After the pipeline-state-list and answer-domain changes landed together, `test_program_answer_domains.py` no longer compiles: the extracted production `record_answers` function reads the thread-local `answers_in`, but the fixture did not define it. The [current main source-regression run](https://github.com/NotRexed/Hookshot/actions/runs/42588468881) fails on both Windows and Linux. Add the fixture's missing input and check that pipeline-state answers are retained in the recorded variant. The renderer and runtime are unchanged. Validation: - Windows Clang/MSVC: reproduced the undeclared identifier on main; the focused fixture now passes its five default/strict environment cases. `python -I -B tests/run_all.py --strict program_answer_domains` passes. - WSL GCC: reproduced the same failure and verified the five cases pass after the fix, with `-D_Static_assert=static_assert` for the local GCC compiler. - A negative control that disables the production `answers_in` branch fails the new assertion. - `git diff --check` passes. Upstream PR checks for this commit have not run yet. Assisted-by: OpenAI Codex

NotRexed commented

2026-11-09 13:33:14 +00:00

(Migrated from github.com)

Thanks! The same fix landed in dev (99e3ce0) through #1077's commit, which reads the declaration from vk_shader.cpp instead of copying it into the test, so I'm closing this one as a duplicate.

Thanks! The same fix landed in `dev` (99e3ce0) through #1077's commit, which reads the declaration from `vk_shader.cpp` instead of copying it into the test, so I'm closing this one as a duplicate.

Commenting is not possible because the repository is archived.

No reviewers