feat: a failure's pictures, kept a day #85
No reviewers
Labels
No labels
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
priority
critical
priority
high
priority
low
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Beanstalk!85
Loading…
Reference in a new issue
No description provided.
Delete branch "HumanBean/Beanstalk:feat/failure-pictures"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Why
When a farm test fails or gets stuck, nobody can see what the game showed. #1359's RADV runs are an example: "a step ran out of time: not met in time" four times. Pictures of the failure, kept for a day, make that debuggable without keeping game pictures forever.
What changed
shotbefore quitting (best effort, 30 s at most).screenshot.max_diff: for these, it keeps main's and the PR's files from the worst pair. Before, it kept the first pair's PR file only.uploadsays. Each is shrunk to fit 960x540 (Png.Shrink) and written as an RGB PNG (Png.Encode, with a CRC table: no new package)."keep": "day".last_frameson a scenario, andkept: {main, pr}on a screenshot.expires_ata day on (migration 0019); the sweeper deletes them after.Rollout
Coordinator first, since an older coordinator would refuse the larger uploads. New agents pick it up from the next nightly.
Tests
keep, count, 2 MB);test_runs_planner::test_planning_again_with_new_wordsfailed 2 times in 5 runs while this PC's load average was 30. It races the background planner, and this change doesn't touch it.